Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(region-info): eu-south-1 (Milan) ROUTE_53_BUCKET_WEBSITE_ZONE_ID #10915

Merged
merged 17 commits into from
Oct 21, 2020
Merged

chore(region-info): eu-south-1 (Milan) ROUTE_53_BUCKET_WEBSITE_ZONE_ID #10915

merged 17 commits into from
Oct 21, 2020

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Oct 16, 2020 •
edited
Loading

hashicorp/terraform-provider-aws#13061

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 16, 2020 •
edited
Loading

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@PatMyron PatMyron changed the title eu-south-1 ROUTE_53_BUCKET_WEBSITE_ZONE_ID eu-south-1 (Milan) ROUTE_53_BUCKET_WEBSITE_ZONE_ID Oct 16, 2020
@PatMyron PatMyron changed the title eu-south-1 (Milan) ROUTE_53_BUCKET_WEBSITE_ZONE_ID feat: eu-south-1 (Milan) ROUTE_53_BUCKET_WEBSITE_ZONE_ID Oct 16, 2020
@SomayaB SomayaB changed the title feat: eu-south-1 (Milan) ROUTE_53_BUCKET_WEBSITE_ZONE_ID feat(region-info): eu-south-1 (Milan) ROUTE_53_BUCKET_WEBSITE_ZONE_ID Oct 16, 2020
shivlaks
shivlaks previously approved these changes Oct 17, 2020
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@shivlaks shivlaks added @aws-cdk/region-info Related to AWS Region information @aws-cdk/aws-route53 Related to Amazon Route 53 labels Oct 17, 2020
@shivlaks shivlaks added the pr-linter/exempt-readme The PR linter will not require README changes label Oct 19, 2020
@mergify mergify bot dismissed shivlaks’s stale review October 19, 2020 22:42

Pull request has been modified.

shivlaks
shivlaks previously approved these changes Oct 19, 2020
View reviewed changes
@shivlaks shivlaks added the pr-linter/exempt-test The PR linter will not require test changes label Oct 19, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@shivlaks shivlaks changed the title feat(region-info): eu-south-1 (Milan) ROUTE_53_BUCKET_WEBSITE_ZONE_ID chore(region-info): eu-south-1 (Milan) ROUTE_53_BUCKET_WEBSITE_ZONE_ID Oct 20, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed shivlaks’s stale review October 21, 2020 01:51

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@shivlaks
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2020

Command refresh: success

Pull request refreshed

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ddfefb5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cc2600f into aws:master Oct 21, 2020
@PatMyron PatMyron deleted the patch-1 branch October 21, 2020 03:14
@PatMyron PatMyron mentioned this pull request Dec 21, 2021
Merged
mergify bot pushed a commit that referenced this pull request Jan 31, 2022
@PatMyron
chore(region-info): ap-southeast-3 (Jakarta) ROUTE_53_BUCKET_WEBSITE_…
b30c3f2 
…ZONE_ID (#18110)

prev: #10915, #17024, hashicorp/terraform-provider-aws#22295, #18300
https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@PatMyron @TikiTDO
chore(region-info): ap-southeast-3 (Jakarta) ROUTE_53_BUCKET_WEBSITE_…
80f8103 
…ZONE_ID (aws#18110)

prev: aws#10915, aws#17024, hashicorp/terraform-provider-aws#22295, aws#18300
https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@PatMyron PatMyron mentioned this pull request Sep 4, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks approved these changes

Assignees

@RomainMuller RomainMuller

Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 @aws-cdk/region-info Related to AWS Region information pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PatMyron @shivlaks @aws-cdk-automation @RomainMuller